fix(aihr): scope unknown mobile supervisors
This commit is contained in:
+1
-1
@@ -1404,7 +1404,7 @@ public class AihrPracticeSeedService {
|
|||||||
LIMIT 1
|
LIMIT 1
|
||||||
""", (rs, rowNum) -> new OrgScopeRow(rs.getString("project_code"), rs.getString("position_level")), ownerArgs.toArray());
|
""", (rs, rowNum) -> new OrgScopeRow(rs.getString("project_code"), rs.getString("position_level")), ownerArgs.toArray());
|
||||||
if (owners.isEmpty()) {
|
if (owners.isEmpty()) {
|
||||||
return TeamScope.unscoped();
|
return TeamScope.scoped(List.of());
|
||||||
}
|
}
|
||||||
OrgScopeRow row = owners.get(0);
|
OrgScopeRow row = owners.get(0);
|
||||||
if (!canSeeProject(row.positionLevel())) {
|
if (!canSeeProject(row.positionLevel())) {
|
||||||
|
|||||||
+14
@@ -107,6 +107,17 @@ public class AihrPracticeSeedServiceTest {
|
|||||||
assertEquals(List.of("000000", "SUP-1", "EMP-1", 5), jdbcTemplate.reviewArgs);
|
assertEquals(List.of("000000", "SUP-1", "EMP-1", 5), jdbcTemplate.reviewArgs);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void pendingReviewRecordsBlocksUnknownSupervisorWhenSnapshotExists() {
|
||||||
|
PracticeReviewJdbcTemplate jdbcTemplate = new PracticeReviewJdbcTemplate(null, List.of());
|
||||||
|
AihrPracticeSeedService service = new AihrPracticeSeedService(new ObjectMapper(), jdbcTemplate, null, null);
|
||||||
|
|
||||||
|
service.pendingReviewRecords("UNKNOWN", "", "", 5);
|
||||||
|
|
||||||
|
assertEquals("", jdbcTemplate.reviewSql);
|
||||||
|
assertEquals(List.of(), jdbcTemplate.reviewArgs);
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void competencyDoesNotSeedScoreForEmptyEmployee() {
|
public void competencyDoesNotSeedScoreForEmptyEmployee() {
|
||||||
JdbcTemplate jdbcTemplate = mock(JdbcTemplate.class);
|
JdbcTemplate jdbcTemplate = mock(JdbcTemplate.class);
|
||||||
@@ -229,6 +240,9 @@ public class AihrPracticeSeedServiceTest {
|
|||||||
if (sql.contains("SELECT project_code") && sql.contains("LIMIT 1")) {
|
if (sql.contains("SELECT project_code") && sql.contains("LIMIT 1")) {
|
||||||
ownerSql = sql;
|
ownerSql = sql;
|
||||||
ownerArgs = List.of(args);
|
ownerArgs = List.of(args);
|
||||||
|
if (ownerLevel == null) {
|
||||||
|
return List.of();
|
||||||
|
}
|
||||||
return mapRows(rowMapper, List.of(Map.of(
|
return mapRows(rowMapper, List.of(Map.of(
|
||||||
"project_code", "P1",
|
"project_code", "P1",
|
||||||
"position_level", ownerLevel
|
"position_level", ownerLevel
|
||||||
|
|||||||
Reference in New Issue
Block a user